Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ValueExpressionVisitor #95

Closed
jakobbraun opened this issue Oct 21, 2020 · 0 comments · Fixed by #101
Closed

Refactor ValueExpressionVisitor #95

jakobbraun opened this issue Oct 21, 2020 · 0 comments · Fixed by #101
Labels
refactoring Code improvement without behavior change

Comments

@jakobbraun
Copy link
Contributor

With adding more and more functions, ValueExpressionVisitor gets longish. We could split it up into two visitors. One for functions and one for literals, or similar.
@jakobbraun jakobbraun added the refactoring Code improvement without behavior change label Oct 21, 2020
jakobbraun added a commit that referenced this issue Oct 28, 2020
@jakobbraun
#95 Refactored ValueExpressionVisitor
6e23ced
@jakobbraun jakobbraun mentioned this issue Oct 28, 2020
Merged
jakobbraun added a commit that referenced this issue Nov 10, 2020
@jakobbraun @redcatbear
Refactor/95 value expression visitor (#101)
6493f7e 
* #95 Refactored `ValueExpressionVisitor`

* removed TreeNode structure; combined BooleanExpressionRenderer and ValueExpressionRenderer

Co-authored-by: Sebastian Bär <sebastian.baer@exasol.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring Code improvement without behavior change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor/95 value expression visitor exasol/sql-statement-builder
1 participant
@jakobbraun