Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#104: Added additional predicates #105

Merged
merged 9 commits into from
Mar 4, 2021
Merged

#104: Added additional predicates #105

merged 9 commits into from
Mar 4, 2021

Conversation

morazow
Copy link
Contributor

@morazow morazow commented Mar 3, 2021

Fixes #104.

@morazow morazow requested a review from jakobbraun March 3, 2021 08:06
jakobbraun
jakobbraun previously approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@jakobbraun jakobbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with on suggestion

src/main/java/com/exasol/sql/expression/predicate/BetweenPredicate.java
/**
* A builder for {@link BetweenPredicate}.
*/
public static class Builder {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a private constructor to hide the public default

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@morazow morazow requested a review from jakobbraun March 3, 2021 12:08
jakobbraun
jakobbraun previously approved these changes Mar 3, 2021
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 4, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@morazow morazow merged commit e9499ae into main Mar 4, 2021
@morazow morazow deleted the feature/#104-add-extra-predicates branch March 4, 2021 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnastasiiaSergienko AnastasiiaSergienko AnastasiiaSergienko approved these changes

@jakobbraun jakobbraun jakobbraun left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for missing predicates
3 participants
@morazow @jakobbraun @AnastasiiaSergienko