Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/117-fix-sonar-issues #118

Merged
merged 12 commits into from
Sep 23, 2021
19 changes: 7 additions & 12 deletions .github/workflows/ci-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,6 @@ on:
jobs:
build:
runs-on: ubuntu-latest
strategy:
matrix:
java: [11]
env:
DEFAULT_JAVA: 11

steps:
- name: Checkout the repository
Expand All @@ -20,34 +15,34 @@ jobs:
- uses: actions/setup-java@v2
with:
distribution: 'zulu'
kaklakariada marked this conversation as resolved.
Show resolved Hide resolved
java-version: ${{ matrix.java }}
java-version: 11

- name: Cache local Maven repository
uses: actions/cache@v2
with:
path: ~/.m2/repository
key: ${{ runner.os }}-java-${{ matrix.java }}-maven-${{ hashFiles('**/pom.xml') }}
key: ${{ runner.os }}-java-11-maven-${{ hashFiles('**/pom.xml') }}
restore-keys: |
${{ runner.os }}-java-${{ matrix.java }}-maven-
${{ runner.os }}-java-11-maven-

- name: Cache SonarQube packages
uses: actions/cache@v2
with:
path: ~/.sonar/cache
key: ${{ runner.os }}-java-${{ matrix.java }}-sonar
restore-keys: ${{ runner.os }}-java-${{ matrix.java }}-sonar
key: ${{ runner.os }}-java-11-sonar
restore-keys: ${{ runner.os }}-java-11-sonar

- name: Run tests and build with Maven
run: mvn --batch-mode --update-snapshots clean verify -DtrimStackTrace=false

- name: Publish Test Report for Java ${{ matrix.java }}
- name: Publish Test Report for Java 11
uses: scacap/action-surefire-report@v1
if: ${{ always() }}
with:
github_token: ${{ secrets.GITHUB_TOKEN }}

- name: Sonar analysis
if: ${{ env.DEFAULT_JAVA == matrix.java && env.SONAR_TOKEN != null }}
if: ${{ env.SONAR_TOKEN != null }}
kaklakariada marked this conversation as resolved.
Show resolved Hide resolved
run: |
mvn --batch-mode sonar:sonar -DtrimStackTrace=false \
-Dsonar.organization=exasol -Dsonar.host.url=https://sonarcloud.io -Dsonar.login=$SONAR_TOKEN
Expand Down
6 changes: 3 additions & 3 deletions doc/changes/changes_4.4.3.md
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
# Exasol SQL Statement Builder 4.4.3, released 2021-09-??

Code name: Internal refactorings
Code name: Internal refactorings on "More Predicates"

## Refactoring

* [#117](https://github.com/exasol/sql-statement-builder/issues/117): Fix sonar findings
* [#117](https://github.com/exasol/sql-statement-builder/issues/117): Fixed sonar findings

## Dependency Updates

### Test Dependency Updates

* Updated `nl.jqno.equalsverifier:equalsverifier:3.6.1` to `3.7.1`
* Updated `org.junit.jupiter:junit-jupiter:5.7.2` to `5.8.0`
* Updated `org.junit.jupiter:junit-jupiter:5.7.2` to `5.8.1`
* Updated `org.mockito:mockito-core:3.10.0` to `3.12.4`
* Updated `org.mockito:mockito-junit-jupiter:3.10.0` to `3.12.4`

Expand Down
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter</artifactId>
<version>5.8.0</version>
<version>5.8.1</version>
<scope>test</scope>
</dependency>
<dependency>
Expand Down