#169: Adapt shared tests to bugfix in Exasol DB #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckunki
requested changes
Sep 23, 2024
| assertThat(exception.getMessage(), containsString( | ||
| "OverflowException: E-VSD-38: A value for column 'EXA_COL' exceeded the configured varcharColumnSize of 6.")); | ||
|
|
||
| this.assertQuery("SELECT * FROM TEST.BOOKS", table("VARCHAR").row("short").row("very_l").matches()); |
There was a problem hiding this comment.
I think the name refreshVirtualSchemaReadsIgnoresNonSchemaChanges of the test case still reflects the old semantics. Maybe we should rename it?
Additionally, I wonder: How could / can the VSDF identify the version of the Exasol database?
Or is this up to the concrete implementations inheriting from VSDF?
In any way: Can and should the VSDF at least signal, which versions of Exasol database are supported or which include the bug and which fix it?
|
ckunki
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #169