Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1212] Switch TSlint to ESlint #1217

Merged
merged 12 commits into from
Oct 7, 2019
Merged

Conversation

eonarheim
Copy link
Member

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Closes #1212

Changes:

  • Update source where needed with new eslint rules
  • Add eslint config + dependencies
  • Update build process to use eslint

@eonarheim eonarheim added the work-in-progress A work in progress pull request, will not be merged until this is removed label Oct 5, 2019
Copy link
Member

@kamranayub kamranayub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, nice job. 👍

@eonarheim eonarheim merged commit 0c01406 into master Oct 7, 2019
@eonarheim eonarheim deleted the feature/1212-tslint-to-eslint branch October 7, 2019 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
work-in-progress A work in progress pull request, will not be merged until this is removed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TSLint is deprecated switch to ESLint
2 participants