Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: specify to use yarn v1 not v2 #3799

Merged
merged 3 commits into from
Jul 5, 2021

Conversation

JakubKoralewski
Copy link
Contributor

got some errors with yarn v2, so had to downgrade
to even start working, I think it's a good idea
to put it in the README

got some errors with yarn v2, so had to downgrade
to even start working, I think it's a good idea
to put it in the README
@vercel
Copy link

vercel bot commented Jul 4, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/excalidraw/excalidraw/Hyr2HtfhfKELe7ofSp8ohpnbnMrS
✅ Preview: https://excalidraw-git-fork-jakubkoralewski-docs-setu-985c9f-excalidraw.vercel.app

@dwelle
Copy link
Member

dwelle commented Jul 4, 2021

Actually, it seems to be a yarn bug that's been fixed: yarnpkg/berry#2935

README.md Outdated Show resolved Hide resolved
@dwelle
Copy link
Member

dwelle commented Jul 4, 2021

@JakubKoralewski lemme know if you were indeed on yarn <2.4.1 or this is a different bug.

@JakubKoralewski
Copy link
Contributor Author

By downgrading I lost the ability to tell which v2 exactly I was on, but now I yarn set version berry again which put me on 2.4.2 and the issue is gone.

README.md Outdated Show resolved Hide resolved
@dwelle
Copy link
Member

dwelle commented Jul 5, 2021

Cool. I've changed the readme to v.2.4.2+ because it's unclear whether 2.4.1 works. The issue mentions 2.4.2, but it wasn't in changelog.

@dwelle
Copy link
Member

dwelle commented Jul 5, 2021

Thanks!

@dwelle dwelle merged commit 3c29555 into excalidraw:master Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants