Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 IMPROVE: Add image options to glue:figure #403

Merged
merged 2 commits into from
Apr 21, 2022
Merged

Conversation

chrisjsewell
Copy link
Member

glue:figure directive options:

Option Type Description
alt text Alternate text of an image
height length The desired height of an image
width length or percentage The width of an image
scale percentage The uniform scaling factor of an image
class text A space-separated list of class names for the image
figwidth length or percentage The width of the figure
figclass text A space-separated list of class names for the figure
name text referenceable label for the figure

@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #403 (d26280f) into master (52f7fb7) will decrease coverage by 7.27%.
The diff coverage is 79.77%.

@@            Coverage Diff             @@
##           master     #403      +/-   ##
==========================================
- Coverage   87.35%   80.07%   -7.28%     
==========================================
  Files          12       20       +8     
  Lines        1368     2053     +685     
==========================================
+ Hits         1195     1644     +449     
- Misses        173      409     +236     
Flag Coverage Δ
pytests 80.07% <79.77%> (-7.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
myst_nb/glue/crossref.py 36.92% <36.92%> (ø)
myst_nb/ext/download.py 50.00% <50.00%> (ø)
myst_nb/glue/roles.py 56.47% <56.47%> (ø)
myst_nb/glue/utils.py 64.86% <64.86%> (ø)
myst_nb/core/lexers.py 86.04% <66.66%> (ø)
myst_nb/glue/directives.py 69.85% <69.85%> (ø)
myst_nb/__init__.py 71.42% <71.42%> (-15.67%) ⬇️
myst_nb/core/loggers.py 76.00% <76.00%> (ø)
myst_nb/docutils_.py 76.27% <76.27%> (ø)
myst_nb/core/config.py 79.54% <79.54%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a48596...d26280f. Read the comment docs.

@chrisjsewell chrisjsewell linked an issue Apr 21, 2022 that may be closed by this pull request
@chrisjsewell chrisjsewell merged commit edb0daf into master Apr 21, 2022
@chrisjsewell chrisjsewell deleted the glue-figure branch April 21, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

alt option for glue:figure directive
1 participant