🔀 MERGE: Add inline execution and variable evaluation #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`hasHandlers` looks through all parent loggers, whereas we only want to check handlers specifically on the logger
This commit restructures the execution phase, to act as a notebook client context manager, within which the renderer runs. This will allow for a kernel client to be running during rendering, and thus for it to be queried for variables.
Make different execution methods subclasses of `NotebookClientBase`
This allows it to work with "inline" execution
Codecov Report
@@ Coverage Diff @@
## master #414 +/- ##
==========================================
+ Coverage 80.88% 81.21% +0.33%
==========================================
Files 22 29 +7
Lines 2176 2523 +347
==========================================
+ Hits 1760 2049 +289
- Misses 416 474 +58
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.