-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️ UPGRADE: Add Python 3.10 support #422
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
Codecov Report
@@ Coverage Diff @@
## master #422 +/- ##
==========================================
+ Coverage 81.21% 81.37% +0.16%
==========================================
Files 29 29
Lines 2523 2551 +28
==========================================
+ Hits 2049 2076 +27
- Misses 474 475 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM - py310 tests seem happy, and I don't know of any reason to suspect 3.10 wouldn't work, so I'm +1 !
I saw that you deleted the commented-out Sphinx 3 line...In my opinion that's OK since we weren't testing it anyway there, and Sphinx 5 is out now so I suspect we should focus our efforts on supporting that.
cheers |
No description provided.