Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: remove python=3.7 as EOL is June 2023 #516

Merged
merged 1 commit into from
May 4, 2023
Merged

Conversation

mmcky
Copy link
Member

@mmcky mmcky commented May 3, 2023

This PR removes python==3.7 from the test suites and list of supported python versions.

https://devguide.python.org/versions/

The deprecation date for 3.7 is coming up in June 2023.

@mmcky
Copy link
Member Author

mmcky commented May 3, 2023

this may help with #479 -- rather than fixing python==3.7 failing tests.

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7164bfd) 81.47% compared to head (255b0ad) 81.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #516   +/-   ##
=======================================
  Coverage   81.47%   81.47%           
=======================================
  Files          29       29           
  Lines        2618     2618           
=======================================
  Hits         2133     2133           
  Misses        485      485           
Flag Coverage Δ
pytests 81.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mmcky
Copy link
Member Author

mmcky commented May 3, 2023

@chrisjsewell do you see any reason to keep python=3.7 support?

I will leave this PR open for review for a couple of days before I merge.

Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @mmcky !

@choldgraf choldgraf merged commit 752d20f into master May 4, 2023
@mmcky mmcky deleted the dep-python37 branch May 5, 2023 01:58
agoose77 pushed a commit to aleivag/MyST-NB that referenced this pull request Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants