MAINT: Patch file_regression fixture for Sphinx backwards compatibility
#536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
agoose77
approved these changes
Sep 18, 2023
|
Thanks for this! It looks correct to me, so we'll merge and see what happens ;) |
|
Congrats on your first merged pull request in this project! 🎉 |
|
It's my intention to do that, but first I'm going to get our CI passing :) |
agoose77
changed the title
file_regression fixture for Sphinx backwards compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR should fix the failing CI for sphinx 7 which adds translation metadata to some of the outputs.
I've patched the file_regression comparison fixture to strip out the differences between sphinx<7 and 7. Hopefully this will allow the merge of #532 #533 and #534 and is maybe enough for a new release as requested in #530.
Thanks!