Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse target as an optional positional argument #94

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

manics
Copy link
Contributor

@manics manics commented Nov 20, 2023

Instead of relying on parsing unknown args add a hidden placeholder positional argument so that target can be passed as a keyword arg, or as the only positional arg

Instead of relying on parsing unknown args add a hidden placeholder positional argument so that target can be passed as a keyword arg, or as the only positional arg
Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice - this looks good to me

@choldgraf choldgraf merged commit f736be7 into executablebooks:main Nov 22, 2023
3 checks passed
@manics manics deleted the target-positional-arg branch November 22, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants