Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 MAINTAIN: Remove upper bound from Python version constraint #40

Merged

Conversation

cjolowicz
Copy link
Contributor

@cjolowicz cjolowicz commented Feb 8, 2022

Fixes #36

@welcome
Copy link

welcome bot commented Feb 8, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #40 (76fbb93) into master (aba72e6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #40   +/-   ##
=======================================
  Coverage   93.19%   93.19%           
=======================================
  Files          25       25           
  Lines        1351     1351           
=======================================
  Hits         1259     1259           
  Misses         92       92           
Flag Coverage Δ
pytests 93.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aba72e6...76fbb93. Read the comment docs.

@cjolowicz
Copy link
Contributor Author

76fbb93 fixes the Read the Docs PR build by upgrading myst-parser to the latest version.

Happy to move this to a separate PR if you prefer.

The PR build failed previously because the rtd extra required myst-parser~=0.14.0, which required mdit-py-plugins~=0.2.8, thereby excluding the current version of this package (0.3.0).

pip output
INFO: pip is looking at multiple versions of mdit-py-plugins[rtd] to determine which version is compatible with other requirements. This could take a while.
ERROR: Cannot install mdit-py-plugins and mdit-py-plugins[rtd]==0.3.0 because these package versions have conflicting dependencies.

The conflict is caused by:
    mdit-py-plugins[rtd] 0.3.0 depends on mdit-py-plugins 0.3.0 (from /Users/cjolowicz/Code/github.com/executablebooks/mdit-py-plugins)
    myst-parser 0.14.0 depends on mdit-py-plugins~=0.2.8

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency conflict

ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts

Copy link
Member

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers!

@chrisjsewell chrisjsewell merged commit e1e5e94 into executablebooks:master Feb 18, 2022
@welcome
Copy link

welcome bot commented Feb 18, 2022

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

@cjolowicz
Copy link
Contributor Author

thanks @chrisjsewell :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants