✨ NEW: Port admon plugin

[KyleKing]

(Partially) Fixes: hukkin/mdformat#309 (in combination with KyleKing/mdformat-admon#1)

I had two hours this morning and tried porting the plugin! It passes all tests locally and seems to work, but I'll take another look through tomorrow to make sure it is merge-ready. I'm opening a PR for now, since there seemed to be a couple of people interested, and I would benefit from any feedback.

[welcome]

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

[KyleKing]

I think this is now ready for review. Let me know if there is anything that needs to be modified, and I would be happy to make those changes, or feel free to go ahead and make changes directly!

Based on this recommendation, this PR ports this JS plugin to Python: https://github.com/commenthol/markdown-it-admon/blob/9820ba89415c464a3cc18a780f222a0ceb3e18bd/index.js

[hukkin]

Thanks! This seems good to me assuming that tests pass.

Would @chrisjsewell be able to approve CI and review too?

[codecov]

Codecov Report

Base: 92.37% // Head: 92.66% // Increases project coverage by +0.28% 🎉

Coverage data is based on head (c690983) compared to base (3f90276).
Patch coverage: 97.08% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   92.37%   92.66%   +0.28%     
==========================================
  Files          27       29       +2     
  Lines        1574     1677     +103     
==========================================
+ Hits         1454     1554     +100     
- Misses        120      123       +3     

Flag	Coverage Δ
pytests	92.66% <97.08%> (+0.28%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
mdit_py_plugins/admon/index.py	97.05% <97.05%> (ø)
mdit_py_plugins/admon/__init__.py	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[hukkin]

Regarding broken CI checks:

• both failures unrelated to this PR
• pre-commit check should be fixed by 🔧 MAINTAIN: Fix pre-commit configuration #54

[KyleKing]

Thanks for the feedback! I think I made all the requested changes. Let me know if there is anything else.

For coverage, is 100% statement coverage expected? There are a few that aren't tested, but they are only single lines like return True or return "", ""

[chrisjsewell]

cheers!

[chrisjsewell]

@hukkin do you want to approve before I merge ta

[hukkin]

LGTM! Thanks @KyleKing !

[welcome]

Congrats on your first merged pull request in this project! 🎉


Thank you for contributing, we are very proud of you! ❤️