Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 Improve field lists #65

Merged
merged 3 commits into from
Feb 18, 2023
Merged

👌 Improve field lists #65

merged 3 commits into from
Feb 18, 2023

Conversation

chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Feb 18, 2023

This introduces better handling of the field list body content, so that it can be dynamically indented (the same as in rST).

Before, one could only indent like:

:name1: first line
              
        all other lines must be aligned with it

:name2:
  
  no first line so 2 space indent

But now, the indentation will be taken as the minimum of all content, e.g.

:name1: first line

 this is indented 1, so all content will follow this

This introduces better handling of the field list body content, so that it can be dynamically indented (the same as in rST).
@codecov
Copy link

codecov bot commented Feb 18, 2023

Codecov Report

Base: 92.76% // Head: 92.87% // Increases project coverage by +0.11% 🎉

Coverage data is based on head (83ac21e) compared to base (9e57524).
Patch coverage: 97.77% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
+ Coverage   92.76%   92.87%   +0.11%     
==========================================
  Files          30       30              
  Lines        1673     1699      +26     
==========================================
+ Hits         1552     1578      +26     
  Misses        121      121              
Flag Coverage Δ
pytests 92.87% <97.77%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mdit_py_plugins/field_list/__init__.py 95.96% <97.77%> (+1.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chrisjsewell chrisjsewell merged commit f4f0a0e into master Feb 18, 2023
@chrisjsewell chrisjsewell deleted the fix-field-lists branch February 18, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant