Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Left ToC and mobile (e.g. jupyter-book gallery) #303

Closed
chrisjsewell opened this issue Mar 17, 2021 · 7 comments
Closed

Issue with Left ToC and mobile (e.g. jupyter-book gallery) #303

chrisjsewell opened this issue Mar 17, 2021 · 7 comments
Labels
bug Something isn't working

Comments

@chrisjsewell
Copy link
Member

chrisjsewell commented Mar 17, 2021

Go-to https://executablebooks.org/en/latest/gallery.html and "squeeze" the window, it's not working like the SBT main page: it does not appear above the main body. and you get lots of space on the left when hidden:

image

Presumably since 76fe7e7?

cc @choldgraf and @DrDrij

@chrisjsewell chrisjsewell added the bug Something isn't working label Mar 17, 2021
@choldgraf
Copy link
Member

choldgraf commented Mar 17, 2021

Ah weird, I didn't notice that in the PR but I def looked on a mobile width. I think it applies to other pages than just the gallery.

@DrDrij
Copy link
Contributor

DrDrij commented Mar 17, 2021

Thanks for identifying. This occurs on pages without a right page TOC.
I can put together a PR to address these pages this evening.

Are there any such pages in the tox tests I can use for testing?

@chrisjsewell
Copy link
Member Author

Cheers

Are there any such pages in the tox tests I can use for testing?

I don't know off-hand I'm afraid. Of course feel free to create one if not

@DrDrij
Copy link
Contributor

DrDrij commented Mar 18, 2021

Hmm, on closer inspection it appears it is an issue with how bootstrap is loaded.

https://sphinx-book-theme.readthedocs.io/en/latest/configure.html
https://executablebooks.org/en/latest/gallery.html

These two sites have the same sphinx-book-theme custom scss, but they cascade bootstrap differently (maybe different versions?). It's hard for me to troubleshoot where the issue is on executablebooks.org as sphinx-book-theme.readthedocs.io works as expected.

@chrisjsewell If you have any clues as to why these two sites differ would be handy :)

What I've amended is using id over class for our custom theme css so that it has higher priority: PR

However, this bug does highlight the potential conflicts with bootstrap. As there is now a set layout for the sphinx-book-theme, I suggest the basic css/js we rewrite with our own classes (but keep bootstrap for anything additional).

image

@choldgraf
Copy link
Member

@DrDrij thanks for this analysis - it feels related to executablebooks/meta#279 as well (which would I think remove our dependency on Bootstrap)

@DrDrij
Copy link
Contributor

DrDrij commented Mar 29, 2021

Tested https://executablebooks.org/en/latest/gallery.html locally with latest sphinx-book-theme css: PR

@choldgraf
Copy link
Member

I believe this was closed by #305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants