-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with Left ToC and mobile (e.g. jupyter-book gallery) #303
Comments
Ah weird, I didn't notice that in the PR but I def looked on a mobile width. I think it applies to other pages than just the gallery. |
Thanks for identifying. This occurs on pages without a right page TOC. Are there any such pages in the tox tests I can use for testing? |
Cheers
I don't know off-hand I'm afraid. Of course feel free to create one if not |
Hmm, on closer inspection it appears it is an issue with how bootstrap is loaded. https://sphinx-book-theme.readthedocs.io/en/latest/configure.html These two sites have the same sphinx-book-theme custom scss, but they cascade bootstrap differently (maybe different versions?). It's hard for me to troubleshoot where the issue is on @chrisjsewell If you have any clues as to why these two sites differ would be handy :) What I've amended is using However, this bug does highlight the potential conflicts with bootstrap. As there is now a set layout for the sphinx-book-theme, I suggest the basic css/js we rewrite with our own classes (but keep bootstrap for anything additional). |
@DrDrij thanks for this analysis - it feels related to executablebooks/meta#279 as well (which would I think remove our dependency on Bootstrap) |
Tested |
I believe this was closed by #305 |
Go-to https://executablebooks.org/en/latest/gallery.html and "squeeze" the window, it's not working like the SBT main page: it does not appear above the main body. and you get lots of space on the left when hidden:
Presumably since 76fe7e7?
cc @choldgraf and @DrDrij
The text was updated successfully, but these errors were encountered: