Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor our HTML to be a bit more sensible #416

Closed
6 of 7 tasks
choldgraf opened this issue Oct 16, 2021 · 1 comment
Closed
6 of 7 tasks

Refactor our HTML to be a bit more sensible #416

choldgraf opened this issue Oct 16, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@choldgraf
Copy link
Member

choldgraf commented Oct 16, 2021

Problem description

In building the theme there are a few places where we have taken shortcuts and generally not tied the HTML / CSS structure to best practices. Originally this was done to speed things up, but we should start doing refactors to improve this structure in order to make the site more maintainable in the future. This will hopefully reduce unexpected CSS behavior and make it easier for folks to grok what is going on.

There are likely a few different places that need work, so we can use this issue as a catch-all for some of the bigger pieces. I'll list the stuff I know of right now that should get re-addressed.

Tasks and updates

A few major issues to tackle:

@choldgraf
Copy link
Member Author

OK I think that we have resolved the bulk of this one, and we have issues to track the remaining items (specifically, executablebooks/meta#576 for the basic-ng switch). We've made some nice incremental progress that will make it easier to make the switch to basic-ng if we like!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done 🎉
Development

Successfully merging a pull request may close this issue.

1 participant