Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] REFACTOR: Re-work HTML structure and CSS #471

Closed
wants to merge 1 commit into from

Conversation

choldgraf
Copy link
Member

@choldgraf choldgraf commented Jan 25, 2022

This is a refactor of our HTML and CSS, with the goal of improving a number of the UI/UX issues on the book theme, tightening up our white space and sizing, using a more sensible set of CSS classes that will make the theme behave more predictably, and adding more functionality for the in-page TOC on mobile widths.

It is WIP and will need to be rebased once #469 is merged in. Posting here now to track ongoing progress.

Major improvements

  • We now use sticky-top to place our sidebar and topbar, rather than fixed, which means it will flow more naturally if things like banners are placed at the top of the page.
  • Sidebar/topbar/toc font is slightly smaller than the main text font to create more space
  • There's more space for the sidebar + toc bar
  • Increased padding for the main content, and improved padding behavior on wide screens + with sidebar collapsed
  • Programmatic definition of our margin size and placement, so that there's less hacky manually-chosen numbers in there
  • The right sidebar is now viewable on mobile, via a button to toggle the toc similarly to the left sidebar
  • The topbar buttons are now divided into two div groups (left and right) and use flexbox to position and center them nicely

closes #392
closes #459 (I think?)
checks off the last two boxes in #416

@choldgraf
Copy link
Member Author

closing in favor of #472

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Left ToC too narrow for nested sections and left body margin too small ENH: Support docutils 0.17.1
1 participant