1.1.0rc PyPi wheels missing

[PhilipVinc]

Describe the bug

The publish to Pypi run failed

https://github.com/executablebooks/sphinx-book-theme/actions/runs/6870341669

Reproduce the bug

List your environment

[agoose77]

So it did! Thank you for reporting.

[choldgraf]

Ugh, it's two failing tests that arguably aren't important for the release to be useful to people.

One is a bug in the sphinx-theme-builder that makes it impossible to build the wheel on windows machines (but we use Linux to build wheels)

One is a bug in the documentation build somewhere (link here). I think we should just build and push it.

I'm not going to be able to take action on this for a bit so @agoose77 feel free to push any changes you want to get this out

[agoose77]

One is a bug in the sphinx-theme-builder that makes it impossible to build the wheel on windows machines (but we use Linux to build wheels)

I'm reluctant to put out an sdist that won't build on Windows, so I'm holding until the upstream bug here is fixed. Let me chase that up ...

[choldgraf]

Here is the issue I opened in the stb repo:

• Build failures on Windows pradyunsg/sphinx-theme-builder#46

[flying-sheep]

There is a giant pile of buggy old releases being pulled in by 1.0, I’m pretty desperate for having a 1.1.0rc wheel on PyPI.

[choldgraf]

@agoose77 doesn't this build failure just mean that people won't be able to develop this theme on windows, not that they won't be able to use it? If that's the case I suggest we just cut a release as an RC. We can fix the windows but in an RC2.

[agoose77]

OK - I was hoping we could just get a proper release done by fixing upstream so that our sdist's aren't buggy. However, we can make an rc, to unblock workflows.

…

On Thu, 23 Nov 2023, 16:21 Chris Holdgraf, ***@***.***> wrote: @agoose77 <https://github.com/agoose77> doesn't this build failure just mean that people won't be able to *develop* this theme on windows, not that they won't be able to *use* it? If that's the case I suggest we just cut a release as an RC. We can fix the windows but in an RC2. — Reply to this email directly, view it on GitHub <#782 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJQZHJ7OZ4GFMRXMYV6BWDYF5ZXVAVCNFSM6AAAAAA7NNVOR2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRUGY4DMMBSGA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[bxdd]

Agree, v1.0.1 has too many bugs

[choldgraf]

OK new pre-release is actually up now!

https://pypi.org/project/sphinx-book-theme/1.1.0rc1/