-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add search field back to sidebar #775
Conversation
@Gouvernathor I've got some changes in this one that are relevant to you, if you want to take a look. Let me know if this is a reasonable step forward to avoid unexpected CSS changes. I think we do want to incorporate improved accessibility, but hopefully this PR does so without changing the defaults as much. I don't want to get into a long debate about minor design details, so please focus your comments on anything really major that is a huge problem as opposed to stuff that might be a matter of preference! (agreeing on design is always a huge challenge haha) |
That sounds great, how can I test how it renders ? I tried editing the .scss files from my local install but it doesn't seem to work. |
I think for now your best bet is to look at the rendered documentation preview from this PR. https://sphinx-book-theme--775.org.readthedocs.build/en/775/ It will be way easier to just check that out and estimate how it would look rather than to build your docs locally with this PR. |
Thanks ! That's more than enough. As for the background color, I would prefer the former color, The "back to top" and research bar changes are great. |
Fair enough - I think keeping the old background color is less messy anyway. I'd rather not change something if we don't have a clear rationale for doing so. I've reverted that back in the last commit |
OK going to merge this one in. I think it's a good enough improvement and is another step to unblocking folks with all the upstream updates. |
This makes minor CSS adjustments to fix some changes made in the latest pydata theme update.
Brief summary:
Issues resolved:
I think this is ready to merge, the two failures aren't related to this PR...