Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS: Improve docs related to text exclusion #187

Conversation

rkdarst
Copy link
Collaborator

@rkdarst rkdarst commented Nov 17, 2022

- As in executablebooks#185, document the current sate of copybutton_exclude and saw
  how to turn it on (since the default just got turned off for
  backwards compat).
- Review: worth a read to make sure it isn't too confusing.
@rkdarst rkdarst force-pushed the docs-fix-excludecss-vs-manual-exclusions branch from 11527dc to 273daf8 Compare November 18, 2022 16:26
@rkdarst
Copy link
Collaborator Author

rkdarst commented Nov 18, 2022

I have updated this docs change with the current state: automatic prompt exclusion is off, how to turn it on, how it conflicts with the other settings. If this is merged, I think you can make a release. Well, I guess technically this wasn't a requirement...

@rkdarst rkdarst changed the title docs/use: Improve docs docs/use: Improve docs related to text exclusion Nov 20, 2022
@rkdarst rkdarst changed the title docs/use: Improve docs related to text exclusion DOCS: Improve docs related to text exclusion Nov 20, 2022
rkdarst added a commit to rkdarst/sphinx-copybutton that referenced this pull request Nov 20, 2022
- Initial draft, also assumes that executablebooks#187 will be merged.
- The full commit history link needs updating.
- I haven't checked anything else that might need doing.
@JonZeolla
Copy link

This was helpful to me, thanks @rkdarst

JonZeolla
JonZeolla previously approved these changes Apr 12, 2023
docs/use.md Outdated Show resolved Hide resolved
Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few quick improvements, thanks for this @rkdarst !

@choldgraf choldgraf merged commit ab414ca into executablebooks:master Apr 14, 2023
choldgraf added a commit that referenced this pull request Apr 14, 2023
- Initial draft, also assumes that #187 will be merged.
- The full commit history link needs updating.
- I haven't checked anything else that might need doing.

Co-authored-by: Chris Holdgraf <choldgraf@berkeley.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants