Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📚 DOCS: Update font awesome icons #64

Merged
merged 5 commits into from
Jul 30, 2022
Merged

📚 DOCS: Update font awesome icons #64

merged 5 commits into from
Jul 30, 2022

Conversation

2bndy5
Copy link
Contributor

@2bndy5 2bndy5 commented May 13, 2022

resolves #38

  • updates the docs about FA usage
  • upgrade FA link in html_css_files to v6.1.1

Notes:
FA v5 seems to have had some "growing pains" in which the fa CSS class might have been required to set the font-family property. It'd probably be best to avoid using FA v5.

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2022

Codecov Report

Merging #64 (570cd78) into main (b44c8fc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #64   +/-   ##
=======================================
  Coverage   88.98%   88.98%           
=======================================
  Files          11       11           
  Lines         917      917           
=======================================
  Hits          816      816           
  Misses        101      101           
Flag Coverage Δ
pytests 88.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b44c8fc...570cd78. Read the comment docs.

docs/conf.py Outdated Show resolved Hide resolved
docs/badges_buttons.md Outdated Show resolved Hide resolved
@chrisjsewell chrisjsewell changed the title [FIX] Update font awesome icons 📚 DOCS: Update font awesome icons Jul 30, 2022
Copy link
Member

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@chrisjsewell chrisjsewell merged commit 6901e05 into executablebooks:main Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Font Awesome Icons are not working
3 participants