-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧪 TESTS: Add testing for Python 3.9 and pygments versions #135
Conversation
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
=======================================
Coverage 92.23% 92.23%
=======================================
Files 2 2
Lines 219 219
=======================================
Hits 202 202
Misses 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Hi @humitos, I've just realised that the new test using I've changed that here to test the latest between 4 and 5, and the new test is now failing. It looks like the JS asset isn't being included when the config option is set. I'm stuck on why this might be, any thoughts? |
I remember running the test and failing locally. Then, after some debugging, I was able to fix it (see this comment #127 (comment) where we talked about this failing test) I'm not sure how the .html/.xml files added to this PR were generated (I didn't upload them in my original PR). So, I'm guessing there is something there that may be conflicting. I'll take a look next week. |
Thanks, I'd totally forgotten about that. Working fine with a copy of the test source files now 😄 |
Excellent! Happy you already fixed it! 💪 |
Adds tesing for:
pygments
versions, in response to Pygments 2.10 tets failures #134sphinx
version above 4 (was previously fixed to==4.0.0b1
)