Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change testing to only cover latest sphinx version #167

Merged
merged 6 commits into from
Jul 2, 2022
Merged

Conversation

foster999
Copy link
Collaborator

@foster999 foster999 commented Jun 26, 2022

Remove sphinx version pinning - only the latest version of sphinx will be fully supported, but previous versions will work if sphinx dependencies (i.e. jinja2) are managed correctly. This is inline with the approach at sphinx
Remove tests that were specific to older versions of sphinx and pygments
Remove jinja2 version pinning, as this is pinned in latest version of sphinx
Added weekly scheduled testing to catch breaking changes in unpinned dependencies
Updated docutils pin to allow use of verison 0.18.x

Will resolve #166 and will resolve #169

@codecov
Copy link

codecov bot commented Jun 26, 2022

Codecov Report

Merging #167 (52bbb21) into master (b9fd7d8) will increase coverage by 4.57%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
+ Coverage   92.69%   97.27%   +4.57%     
==========================================
  Files           2        2              
  Lines         219      220       +1     
==========================================
+ Hits          203      214      +11     
+ Misses         16        6      -10     
Flag Coverage Δ
pytests 97.27% <ø> (+4.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sphinx_tabs/tabs.py 97.24% <0.00%> (+4.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9fd7d8...52bbb21. Read the comment docs.

@foster999
Copy link
Collaborator Author

Following the changes yesterday, I'm now planning on only testing against the latest sphinx and pygments versions here. This will simplify the testing outcomes and help us to be a bit more reactive with new versions of our dependencies. @Daltz333 does this seem reasonable?

@foster999 foster999 merged commit 26bad87 into master Jul 2, 2022
@foster999 foster999 deleted the sphinx-5-only branch July 2, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please provide support for docutils 0.18.x RFE: please provide support for jinja2 >= 3.0.0
1 participant