-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the tests pass with Sphinx 7.1 #178
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
Thanks for raising the PR |
I disabled this feature only in tests, it won't be disabled for sphinx-tabs users. When you decide to drop support for old Sphinx versions (< 7.1), you can revert this change and update the test expectations instead. |
I think it would be best for the tests to reflect the latest sphinx version. We should be able to fix this by regenerating the regression tests under a normal test run |
But then the tests will fail with older Sphinx. Although, I can put some |
Update the expected XML files to match Sphinx 7.1 output, and patch Sphinx < 7.1 output to match our new expectations.
I have implemented the approach from my last comment now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The tests were failing with this diff:
See https://bugs.debian.org/1042589 for the full log.
This was caused by sphinx-doc/sphinx#11509, which is part of Sphinx ≥ 7.1.0.