-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Concepts/functions generating functions #589
Concepts/functions generating functions #589
Conversation
Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed. That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
This looks really good so if you'd like, we could get the concept merged first. It looks like it's just missing the The only feedback I have is that the examples might be easier to read without assigning them to vars, at least to my eye it would be cleaner that way... or maybe just add a newline or two to keep them from running too far to the right (the final rendered page stuffs them into a narrow code box, so I usually try to keep it from needing to be horizontally scrolled). Thanks! |
…fig.json and updated links.json
Many thanks @bobbicodes. I did as you suggested and added newlines for better readability. This option seemed to make it a bit more explicit the fact that we are generating new functions that later can be called with other arguments. Please let me know if there's still the issue of horizontally scrolling... (I can't see that in my markdown editor sorry!). I also added the .meta/config.json file and updated links.json. Thanks for your feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to include this file?
All that's left is to add this to {
"uuid": "9d9d7cf1-8504-4f7b-b2a0-1b3b638dc0d9",
"slug": "functions-generating-functions",
"name": "Functions generating functions"
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The about page should contain the same content as introduction.md
(or more, but not less)
…d config.json, and made about.md have the same content as introduction.md
Great, many thanks for your help. I included the three changes you indicated. I just read about the configlet tool, and will make sure to include the UIUUD on a next occasion. Apologies for missing that! |
This is great, thanks a lot! |
Added functions-generating-functions concept