Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

say: Sync with problem specifications #662

Merged
merged 4 commits into from
Sep 6, 2024
Merged

Conversation

tasxatzial
Copy link
Member

Also closes #302, as the 'extensions' section mentioned in #302 no longer exists in the synced version.

Copy link
Contributor

github-actions bot commented Sep 6, 2024

Hello 👋 Thanks for your PR.

This repo does not currently have dedicated maintainers. Our cross-track maintainers team will attempt to review and merge your PR, but it will likely take longer for your PR to be reviewed.

If you enjoy contributing to Exercism and have a track-record of doing so successfully, you might like to become an Exercism maintainer for this track.

Please feel free to ask any questions, or chat to us about anything to do with this PR or the reviewing process on the Exercism forum.

(cc @exercism/cross-track-maintainers)

Copy link
Contributor

github-actions bot commented Sep 6, 2024

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

Copy link
Contributor

@michalporeba michalporeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will potentially make some solutions to fail, so they should be regenrated, but at the same time we should merge it to conform to the problem specification.

@michalporeba michalporeba merged commit ffa49cf into exercism:main Sep 6, 2024
5 checks passed
@tasxatzial tasxatzial deleted the say branch September 6, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"say" exercise doesn't use "and" in hundreds
2 participants