Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kindergarten-garden: Sync tests #683

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

tasxatzial
Copy link
Member

@tasxatzial tasxatzial commented Oct 10, 2024

Sync and complete rewrite of all tests.

Coming up with appropriate names for each deftest is nearly impossible for this exercise since the test descriptions are overly long, and some tests are nested three levels deep. So, I just used the test-<uuid> naming convention proposed in issue #673.

I also used one deftest per test, as suggested in the aforementioned issue.

Note: There are multiple issues with the error messages when >1 tests are placed under a single deftest. I'll open an issue about that soon in the test runner repo.

Copy link
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

Copy link
Member

@iHiD iHiD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock

@tasxatzial tasxatzial merged commit c283f00 into exercism:main Oct 25, 2024
5 checks passed
@tasxatzial tasxatzial deleted the kindergarten-garden branch October 25, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants