Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to GnuCOBOL 3.2 #16

Merged
merged 2 commits into from
Apr 2, 2024
Merged

upgrade to GnuCOBOL 3.2 #16

merged 2 commits into from
Apr 2, 2024

Conversation

axtens
Copy link
Member

@axtens axtens commented Mar 24, 2024

A student notified me of the fact that the documentation says B-OR but the current compiler doesn't take without complaint. 3.2 has been out for a while and is stable.

@axtens axtens requested a review from a team as a code owner March 24, 2024 09:55
@axtens
Copy link
Member Author

axtens commented Mar 24, 2024

Looks like the tests will have to be re-examined.

@ErikSchierboom
Copy link
Member

@axtens The expected results have changed a bit with this change. The easiest way to remedy this is to:

  1. Run ./bin/run-tests-in-docker.sh
  2. Run find tests -name results.json -execdir cp results.json expected_results.json \;
  3. Inspect the git diff to see if the changes make sense
  4. If they do, update the PR

@axtens
Copy link
Member Author

axtens commented Mar 27, 2024

Thank you!

@axtens
Copy link
Member Author

axtens commented Mar 31, 2024

@ErikSchierboom PR updated. Ready to go.

Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ErikSchierboom ErikSchierboom merged commit bbc4d07 into exercism:main Apr 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants