Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configlet sync doesn't work yet with the new Exercism v3 track structure #174

Closed
ee7 opened this issue Feb 7, 2021 · 1 comment · Fixed by #175
Closed

configlet sync doesn't work yet with the new Exercism v3 track structure #174

ee7 opened this issue Feb 7, 2021 · 1 comment · Fixed by #175
Assignees
@ee7
Labels
cmd: sync kind: bug User-facing incorrect behavior

Comments

@ee7
Copy link
Member

ee7 commented Feb 7, 2021

To reproduce, download a track repo and run fetch-configlet:

$ git clone --depth 1 https://github.com/exercism/csharp
Cloning into 'csharp'...
...

$ cd csharp
$ bin/fetch-configlet

Now run e.g. configlet sync --check, and note that it thinks that every test case is missing:

$ bin/configlet sync --check
Checking exercises...
Cloning the problem-specifications repo into /tmp/csharp/.problem-specifications...
[warn] acronym: missing 9 test cases
       - basic (1e22cceb-c5e4-4562-9afe-aef07ad1eaf4)
       - lowercase words (79ae3889-a5c0-4b01-baf0-232d31180c08)
       - punctuation (ec7000a7-3931-4a17-890e-33ca2073a548)
       - all caps word (32dd261c-0c92-469a-9c5c-b192e94a63b0)
       - punctuation without whitespace (ae2ac9fa-a606-4d05-8244-3bcc4659c1d4)
       - very long abbreviation (0e4b1e7c-1a6d-48fb-81a7-bf65eb9e69f9)
       - consecutive delimiters (6a078f49-c68d-4b7b-89af-33a1a98c28cc)
       - apostrophes (5118b4b1-4572-434c-8d57-5b762e57973e)
       - underscore emphasis (adc12eab-ec2d-414f-b48c-66a4fc06cdef)
[warn] affine-cipher: missing 16 test cases
...etc

I'll fix this soon. Some of the recent linting work was more important: at the moment, track maintainers generally have a lot to do other than updating their track's (now-)practice exercises.
@ee7 ee7 pinned this issue Feb 7, 2021
@ee7 ee7 self-assigned this Feb 7, 2021
ee7 added a commit to ee7/exercism-configlet that referenced this issue Feb 8, 2021
@ee7
sync: fix for Exercism v3 track structure
75c0c15 
The first "prepare for Exercism v3" PR on every track was merged
by 2021-02-05. This changed the track structure of every track: Exercism
v2 exercises are now "practice exercises" and have been moved to a
different path, which caused `configlet sync` to believe that all test
cases are missing.

Fixes: exercism#174
@ee7 ee7 mentioned this issue Feb 8, 2021
Merged
@ee7 ee7 closed this as completed in #175 Feb 9, 2021
ee7 added a commit that referenced this issue Feb 9, 2021
@ee7
sync: fix for Exercism v3 track structure (#175)
f8a9b82 
The first "prepare for Exercism v3" PR on every track was merged
by 2021-02-05. This changed the track structure of every track: Exercism
v2 exercises are now "practice exercises" and have been moved to a
different path, which caused `configlet sync` to believe that all test
cases are missing.

Fixes: #174
@ee7 ee7 unpinned this issue Feb 9, 2021
@ee7
Copy link
Member Author

ee7 commented Feb 9, 2021

Fixed in the new release.

See https://github.com/exercism/configlet/releases/tag/4.0.0-alpha.3

@ee7 ee7 added cmd: sync kind: bug User-facing incorrect behavior labels May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ee7 ee7

Labels
cmd: sync kind: bug User-facing incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sync: fix for Exercism v3 track structure ee7/exercism-configlet
1 participant
@ee7