-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync: deprecated exercises are included in output #518
Comments
I've moved this to the configlet repo. |
Oopsie, that's where I wanted to post this. Thanks @ErikSchierboom! |
I guess Agreed? Otherwise, there isn't much point in allowing a deprecated exercise to be updated in |
Yes, exactly. |
Agreed! |
The accumulate exercise is deprecated, but configlet is warning that it is outdated, so I decided to sync it and exclude all the new tests. Configlet has an open issue about not linting these (exercism/configlet#518).
The accumulate exercise is deprecated, but configlet is warning that it is outdated, so I decided to sync it and exclude all the new tests. Configlet has an open issue about not linting these (exercism/configlet#518).
Before this commit, `configlet sync` operated on every practice exercise in the track-level `config.json` file, even if the exercise had a `status` of `deprecated`. For example, if only `accumulate` and `binary` are deprecated on the track, and `word-count` has unsynced tests, we might see: $ configlet sync Updating cached 'problem-specifications' data... Checking exercises... [warn] docs: instructions unsynced: accumulate [warn] metadata: unsynced: binary [warn] accumulate: missing 6 test cases - accumulate empty (64d97c14-36dd-44a8-9621-2cecebd6ed23) - accumulate squares (00008ed2-4651-4929-8c08-8b4dbd70872e) - accumulate upcases (551016da-4396-4cae-b0ec-4c3a1a264125) - accumulate reversed strings (cdf95597-b6ec-4eac-a838-3480d13d0d05) - accumulate recursively (bee8e9b6-b16f-4cd2-be3b-ccf7457e50bb) - accumulate recursively (0b357334-4cad-49e1-a741-425202edfc7c) [warn] word-count: missing 1 test case - quotation for word with apostrophe (6d00f1db-901c-4bec-9829-d20eb3044557) [warn] some exercises have unsynced docs [warn] some exercises have unsynced metadata [warn] some exercises are missing test cases With this commit, `configlet sync` ignores practice exercises that are deprecated on the track: $ configlet sync Updating cached 'problem-specifications' data... Checking exercises... [warn] word-count: missing 1 test case - quotation for word with apostrophe (6d00f1db-901c-4bec-9829-d20eb3044557) [warn] some exercises are missing test cases Note that `configlet sync` will still operate on an exercise that is deprecated only in problem-specifications. Fixes: #518
I ran
configlet sync
in the JavaScript track and it reportedBut the accumulate exercise is depreacted, both in the problem spec repo and in the JavaScript track config.json.
So it looked like a bug too me that it is still reported as "not in sync".
Configlet version: 4.0.0-alpha.36
The text was updated successfully, but these errors were encountered: