Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completions: add zsh #633

Closed
ee7 opened this issue Aug 4, 2022 · 0 comments · Fixed by #653
Closed

completions: add zsh #633

ee7 opened this issue Aug 4, 2022 · 0 comments · Fixed by #653
Assignees
Labels
kind: feature User-facing enhancement

Comments

@ee7
Copy link
Member

ee7 commented Aug 4, 2022

Follow-up from #629.

@ee7 ee7 added the kind: feature User-facing enhancement label Aug 4, 2022
@ee7 ee7 self-assigned this Aug 7, 2022
@ee7 ee7 mentioned this issue Aug 7, 2022
@ee7 ee7 closed this as completed in #653 Aug 13, 2022
ee7 added a commit that referenced this issue Aug 13, 2022
Add a zsh completion script and the ability to run

    configlet completion --shell zsh

to write that script to stdout.

This commit also bumps the version of the shellcheck action, which is
necessary to prevent the action from running `shellcheck` on the new zsh
script. Shellcheck does not support zsh, so CI would indicate an error
otherwise.

The bump must be to the latest commit - we already used the latest
release (1.1.0). An upstream commit [1] that claims to exclude zsh
scripts seems to be insufficient - we need to use the `ignore_names`
input that does not exist in the latest release [2].

[1] ludeeus/action-shellcheck@ceeca77f6538
[2] ludeeus/action-shellcheck@c2b45ddc5f85

Closes: #633
@ee7 ee7 moved this to Done in Configlet roadmap Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: feature User-facing enhancement
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant