Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: add runtime/wasmtime tag #195

Merged
merged 1 commit into from
Feb 24, 2021
Merged

lint: add runtime/wasmtime tag #195

merged 1 commit into from
Feb 24, 2021

Conversation

ErikSchierboom
Copy link
Member

No description provided.

Support the recently added "runtime/wasmtime" tag. See exercism/docs#64
Copy link
Member

@ee7 ee7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion on the tag itself, but I do think it's useful for a student to filter for tracks that have good support for doing WebAssembly things. And this just keeps configlet in sync with the docs/website - approved.


As an aside: I guess we won't change the list of valid tags much after a certain point, but it might still be worth considering if we want a single source of truth for them across Exercism (rather than needing to keep them in-sync across repos).

I don't see an obvious best implementation, though. Some options:

  1. Make some file in this repo the source of truth, and read/process it at compile-time. The other repos would use/refer to this file.
  2. Make some file in the exercism/docs repo the source of truth, and add it in this repo as a git submodule/subtree/subrepo. Again, read/process it at compile-time.
  3. Download a file from e.g. exercism/docs at compile-time (I'd vote against this: I don't want to make an internet connection a hard requirement for building configlet).
  4. Make configlet download the list of valid tags at run-time, perhaps only when running in CI or after an opt-in. I wouldn't want to introduce an internet connection as a hard requirement just for linting tags, but if we do that for checking UUIDs Exercism-wide then this might make the most sense.

But I'm fine with the current approach, at least for now.

@ErikSchierboom
Copy link
Member Author

As an aside: I guess we won't change the list of valid tags much after a certain point, but it might still be worth considering if we want a single source of truth for them across Exercism (rather than needing to keep them in-sync across repos).

Yeah, I briefly thought about this too. We might even make it as simple as there running a GitHub actions workflow to detect changes to the list (presumably listed in a file in this repo) and then creating an issue to update in the other repo(s).

@ErikSchierboom ErikSchierboom merged commit f162e61 into main Feb 24, 2021
@ee7 ee7 deleted the runtime-wastime-tag branch February 24, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants