console: write more things to stderr #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikSchierboom
commented
Mar 3, 2021
ee7
reviewed
Mar 11, 2021
We can argue that this message isn't really the "output" of the tests, but is just a temporary communication to the user that the program hasn't hung unexpectedly. `unittest` writes everything to stdout, and so with this commit, the user who compiles the tests and runs ``` $ ./tests/all_tests > /tmp/configlet_test_results.txt ``` will no longer see the message in that file - they see it in their terminal instead.
Rationale: - When the user writes `--help`, the help message should go to stdout. - When the user writes some incorrect options/arguments, the help message should go to stderr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale:
--help, the help message should go to stdout.message should go to stderr.