exec, tests: consolidate git procs #380

ee7 · 2021-06-29T11:29:34Z

Summary:

Add a src/exec.nim file, containing helpers for startProcess.
Move the cloneExercismRepo proc there.
Add a setupExercismRepo proc for combined clone + checkout.
Start using these procs in the tests.

This PR is a follow-up of #379, where I wrote:

I was going to push these changes (and much more upcoming) to #366, but it makes that PR (and eventual squashed commit) too large - it'll already be pretty big. So I want to merge a few PRs first - this won't slow things down more. I consider adding decent tests one of the biggest parts of #366, so in this case I want to not hate the initial state of the new tests.

The next PR will improve the cloning process further, so we'll just have setupExercismRepo at the call site that does "clone if necessary, and checkout".

I think I've finally figured out an ergonomic design for some exec/git helper commands, so they'll soon infect the rest of our codebase too.

See the individual commits.

The hard question: can we think of a better name than myExecCmdEx? I might use just exec instead - it's hard for a reader to confuse with nimscript.exec because that proc doesn't return anything.

A later PR will make src/probspecs.nim also use this shared code. And other things in tests/test_binary.nim too.

src/exec.nim

I adapted this from my own code, where the `command` param is instead `path` - the location of the executable - and `poUsePath` is not a default option.

There is also proc named `exec` in the `nimscript` module, but that one doesn't return a value.

It's more like "perform a shallow clone", not "is a shallow clone".

ee7 added 8 commits June 29, 2021 13:22

exec, tests(binary): use helpers for exec and git

1d8de00

exec, tests(binary): move cloneExercismRepo

f346979

exec: improve doc comment for cloneExercismRepo

4460acc

exec, tests(binary): check dir inside cloneExercismRepo

5ba58d6

exec, tests(binary): improve git checkout usage

ede9b8c

exec, tests(binary): add proc for combined clone + checkout

6d775bf

tests(probspecs): use cloneExercismRepo helper

10472f6

tests(tracks): use git helper

a02c8bf

ee7 requested a review from ErikSchierboom as a code owner June 29, 2021 11:29

ee7 commented Jun 29, 2021

View reviewed changes

src/exec.nim Outdated Show resolved Hide resolved

ErikSchierboom approved these changes Jun 29, 2021

View reviewed changes

src/exec.nim Outdated Show resolved Hide resolved

ee7 added 5 commits June 29, 2021 14:04

exec: fix doc comment

60e468a

I adapted this from my own code, where the `command` param is instead `path` - the location of the executable - and `poUsePath` is not a default option.

exec: rename myExecCmdEx to exec

53e1e21

There is also proc named `exec` in the `nimscript` module, but that one doesn't return a value.

exec: only export necessary procs, for now

ebfdd14

exec, tests(probspecs): rename isShallow to shallow

b655229

It's more like "perform a shallow clone", not "is a shallow clone".

tests(tracks): fix long line

5514629

ee7 merged commit 31ed8d3 into exercism:main Jul 1, 2021

ee7 deleted the tests-refactor-exec-and-git branch July 1, 2021 06:58

ee7 changed the title ~~tests: refactor to share code for exec and git~~ exec, tests: consolidate git procs Jul 1, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

exec, tests: consolidate git procs #380

exec, tests: consolidate git procs #380

ee7 commented Jun 29, 2021 •

edited

Loading

exec, tests: consolidate git procs #380

exec, tests: consolidate git procs #380

Conversation

ee7 commented Jun 29, 2021 • edited Loading

ee7 commented Jun 29, 2021 •

edited

Loading