Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint(track_config): check hello-world status #436

Merged
merged 7 commits into from
Oct 7, 2021
Merged

lint(track_config): check hello-world status #436

merged 7 commits into from
Oct 7, 2021

Commits on Oct 6, 2021

  1. Add validation rule 

    The "exercises.practice[].status" value must, if "exercises.practice[].slug" is equal to hello-world, be either omitted or the string active

Refs: exercism#249
    @bobtfish
    bobtfish committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    5040463 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2021

  1. s/statusKey/statusVal

    @ee7
    ee7 committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    bb97055 View commit details
    Browse the repository at this point in the history

  2. prefer != to not

    @ee7
    ee7 committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    e746dfc View commit details
    Browse the repository at this point in the history

  3. prefer q when there's no "context"

    @ee7
    ee7 committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    a2e39d4 View commit details
    Browse the repository at this point in the history

  4. split long line

    @ee7
    ee7 committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    3c5bb19 View commit details
    Browse the repository at this point in the history

  5. refactor formatting of JSON "context"

    @ee7
    ee7 committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    179085a View commit details
    Browse the repository at this point in the history

  6. bikeshed error message 

    With the previous wording of:

    the value must be [...] `active` or absent

the "value is absent" might be understood as "the value is the empty
string".

This commit tries to clarify, but the wording is a bit clunky. It
doesn't matter much either way, since this error message will probably
be rarely seen.
    @ee7
    ee7 committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    42b8e86 View commit details
    Browse the repository at this point in the history