completions(fish): remove invalid file completions #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, tab completion after a command/option that does
not take an argument would suggest files and directories:
$ bin/configlet sync [Tab]
bin/ config.json docs/ LICENSE README.md
CODE_OF_CONDUCT.md config/ exercises/ mix.exs reference/
concepts/ CONTRIBUTING.md HELLO.md mix.lock
even though adding such an argument would produce an error.
Remove those completions across the whole command, and then add them
only where we want them (directory completions for -t/--track-dir). This
also improves the completions for -t/--track-dir, since it would
previously suggest both files and directories.
ErikSchierboom
approved these changes
Aug 16, 2022
ee7
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the fish completions, writing a command or option that does not
take an argument and then pressing tab would suggest files and
directories:
even though adding such an argument would produce an error.
Remove those completions across the whole command, and then add them
only where we want them (directory completions for
-t/--track-dir). Thisalso improves the completions for
-t/--track-dir, since it wouldpreviously suggest both files and directories.
Docs: