generate: allow a concept slug to contain digits #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A concept slug is allowed to contain digits [1], but `configlet generate`
did not support them.
With this commit, `configlet generate` now behaves as expected for an
`introduction.md.tpl` file like:
# Introduction
%{concept: basics-1}
[1] https://github.com/exercism/docs/blob/ba3eba34d334/building/configlet/lint.md#glossary
Closes: 663
ee7
commented
Sep 27, 2022
ErikSchierboom
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A concept slug is allowed to contain digits:
but
configlet generatedid not support such a slug.With this commit,
configlet generatenow behaves as expected for anintroduction.md.tplfile like:# Introduction %{concept: basics-1}Fixes: #663