Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: allow passing both -uy and --tests include|exclude #674

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

ee7
Copy link
Member

@ee7 ee7 commented Oct 9, 2022

Before this commit:

$ configlet sync -uy --docs --tests include
Error: '-y, --yes' was provided to non-interactively update, but the tests updating mode is still 'choose'.

With this commit:

$ configlet sync -uy --docs --tests include
Updating cached 'problem-specifications' data...
Checking exercises...
Every exercise has up-to-date docs!
Every exercise has up-to-date tests!

Fixes: #673

Before this commit:

    $ configlet sync -uy --docs --tests include
    Error: '-y, --yes' was provided to non-interactively update, but the tests updating mode is still 'choose'.

With this commit:

    $ configlet sync -uy --docs --tests include
    Updating cached 'problem-specifications' data...
    Checking exercises...
    Every exercise has up-to-date docs!
    Every exercise has up-to-date tests!

Fixes: 673
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

Copy link
Member

@kytrinyx kytrinyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ee7
Copy link
Member Author

ee7 commented Oct 11, 2022

I've written some passing tests for this, but they'll benefit from some bikeshedding of the error message.

So I'll merge this sooner rather than later to get the actual fix in a release faster.

@ee7 ee7 merged commit d5f5485 into exercism:main Oct 11, 2022
@ee7 ee7 deleted the sync-fix-yes-tests-include branch October 11, 2022 13:52
@ee7 ee7 changed the title sync: allow passing both --yes and --tests include|exclude sync: allow passing both -uy and --tests include|exclude Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sync: can't sync everything including tests
3 participants