Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch-configlet: print success message #689

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

ee7
Copy link
Member

@ee7 ee7 commented Oct 26, 2022

Before this commit, fetch-configlet produced no output on success:

$ scripts/fetch-configlet
$ echo $?
0

With this commit, it prints a message while downloading, and then prints the downloaded configlet version and its location:

$ scripts/fetch-configlet
Fetching configlet...
Downloaded configlet 4.0.0-beta.7 to ./bin/configlet

Closes: #459

@verdammelt
Copy link
Member

My reading of the change makes it look like these messages are going to stderr? Why stderr rather than stdout?

@ee7
Copy link
Member Author

ee7 commented Oct 26, 2022

My reading of the change makes it look like these messages are going to stderr? Why stderr rather than stdout?

Only the "downloading..." message is going to stderr.

I believe it's common for that kind of message to go to stderr. See:

$ cd /tmp
$ git clone --depth 1 https://github.com/exercism/common-lisp > /dev/null
Cloning into 'common-lisp'...
remote: Enumerating objects: 1059, done.
remote: Counting objects: 100% (1059/1059), done.
remote: Compressing objects: 100% (899/899), done.
remote: Total 1059 (delta 71), reused 700 (delta 46), pack-reused 0
Receiving objects: 100% (1059/1059), 355.08 KiB | 3.37 MiB/s, done.
Resolving deltas: 100% (71/71), done.
$ git clone --depth 1 https://github.com/exercism/ruby 2>/dev/null
$ echo $?
0

Before this commit, `fetch-configlet` produced no output on success:

    $ scripts/fetch-configlet
    $ echo $?
    0

With this commit, it prints a message while downloading, and then prints
the downloaded configlet version and its location:

    $ scripts/fetch-configlet
    Fetching configlet...
    Downloaded configlet 4.0.0-beta.7 to ./bin/configlet

Closes: 459
@ee7 ee7 force-pushed the fetch-configlet-print-success branch from a06db77 to 8bdb280 Compare October 31, 2022 21:44
@ee7 ee7 merged commit 5f5b54d into exercism:main Oct 31, 2022
@ee7 ee7 deleted the fetch-configlet-print-success branch October 31, 2022 21:54
petertseng pushed a commit to petertseng/exercism-rust that referenced this pull request Nov 17, 2022
Before this commit, `fetch-configlet` produced no output on success:

    $ bin/fetch-configlet
    $ echo $?
    0

With this commit, it prints a message while downloading, and then prints
the downloaded configlet version and its location:

    $ bin/fetch-configlet
    Fetching configlet...
    Downloaded configlet 4.0.0-beta.7 to ./bin/configlet

Closes: exercism/configlet#459
exercism/configlet#689
petertseng pushed a commit to petertseng/exercism-haskell that referenced this pull request Nov 17, 2022
Before this commit, `fetch-configlet` produced no output on success:

    $ bin/fetch-configlet
    $ echo $?
    0

With this commit, it prints a message while downloading, and then prints
the downloaded configlet version and its location:

    $ bin/fetch-configlet
    Fetching configlet...
    Downloaded configlet 4.0.0-beta.7 to ./bin/configlet

Closes: exercism/configlet#459
exercism/configlet#689
petertseng pushed a commit to petertseng/exercism-haskell that referenced this pull request Nov 17, 2022
Before this commit, `fetch-configlet` produced no output on success:

    $ bin/fetch-configlet
    $ echo $?
    0

With this commit, it prints a message while downloading, and then prints
the downloaded configlet version and its location:

    $ bin/fetch-configlet
    Fetching configlet...
    Downloaded configlet 4.0.0-beta.7 to ./bin/configlet

exercism/configlet#459
exercism/configlet#689
petertseng pushed a commit to petertseng/exercism-rust that referenced this pull request Nov 17, 2022
Before this commit, `fetch-configlet` produced no output on success:

    $ bin/fetch-configlet
    $ echo $?
    0

With this commit, it prints a message while downloading, and then prints
the downloaded configlet version and its location:

    $ bin/fetch-configlet
    Fetching configlet...
    Downloaded configlet 4.0.0-beta.7 to ./bin/configlet

exercism/configlet#459
exercism/configlet#689
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fetch-configlet: print something on success
3 participants