Feature: Add --offline option
#71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivations: 1. It allows us to establish an initial state for a `problem-specifications` directory, which means we can do black-box testing of the release binary. That is, we wouldn't be able to assert the exact outcome after running the binary if the `problem-specifications` directory is always different at the start of testing. 2. Maintainers can still use the tool even when they have no internet connection, or a very bad one. 3. Maintainers might want a "trust me, I know what I'm doing" switch so that they don't have to wait for a `git fetch`, knowing that `problem-specifications` doesn't update that often. 4. Developers of `canonical_data_syncer` can also benefit from 3 and 4. Decisions: - Implement this as an `--offline` flag, rather than an `--online` flag. The current implementation is seen as harder to misuse. Closes: exercism#66
ee7
added a commit
to ee7/exercism-configlet
that referenced
this pull request
Jan 21, 2021
Motivations: 1. It allows us to establish an initial state for a `problem-specifications` directory, which means we can do black-box testing of the release binary. That is, we wouldn't be able to assert the exact outcome after running the binary if the `problem-specifications` directory is always different at the start of testing. 2. Maintainers can still use the tool even when they have no internet connection, or a very bad one. 3. Maintainers might want a "trust me, I know what I'm doing" switch so that they don't have to wait for a `git fetch`, knowing that `problem-specifications` doesn't update that often. 4. Developers of `canonical_data_syncer` can also benefit from 3 and 4. Decisions: - Implement this as an `--offline` flag, rather than an `--online` flag. The current implementation is seen as harder to misuse. Closes: exercism#66
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivations:
problem-specificationsdirectory, which means we can do black-box testing of the release binary. That is, we wouldn't be able to assert the exact outcome after running the binary if theproblem-specificationsdirectory is always different at the start of testing.git fetch, knowing thatproblem-specificationsdoesn't update that often.canonical_data_syncercan also benefit from 3 and 4.Decisions:
--offlineflag, rather than an--onlineflag. The current implementation is seen as harder to misuse.Closes: #66