lint(track_config): change average_run_time from a float to an int
#765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having the average run time as a float gives the impression of being exact, whereas the actual run time wildly varies due to a wide variety of reasons. A second downside is that `jq`, which is often used to work with track config files, will remove any trailing `.0` from a number, which caused linting to fail.
kytrinyx
approved these changes
Jul 12, 2023
ee7
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the average run time as a float gives the impression of being
exact, whereas the actual run time wildly varies due to a wide variety
of reasons.
A second downside is that
jq, which is often used to work withtrack config files, will remove any trailing
.0from a number,which caused linting to fail.
When we release this, I'll do a bulk update of the track configs.
See exercism/docs#430
Closes: #734