-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create: allow specifying author
and difficulty
#864
Merged
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
6e76aa4
Support specifying the author and/or difficulty when creating exercises.
ErikSchierboom a23f944
Update usage in readme
ErikSchierboom 1318150
Add tests
ErikSchierboom 5130613
Fix invalid text
ErikSchierboom 80f9c80
Fixc whitespace
ErikSchierboom 4c4a960
Add binary tests
ErikSchierboom File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
import std/[os, strformat] | ||
import std/[options, os, strformat] | ||
import ".."/[cli, helpers, sync/sync, types_track_config] | ||
import "."/[approaches, articles, exercises] | ||
|
||
|
@@ -13,6 +13,10 @@ proc create*(conf: Conf) = | |
let msg = &"Both --approach and --article were provided. Please specify only one." | ||
stderr.writeLine msg | ||
quit QuitFailure | ||
if conf.action.difficulty.isSome: | ||
let msg = "The difficulty argument is not supported for approaches" | ||
stderr.writeLine msg | ||
quit QuitFailure | ||
let trackConfigPath = conf.trackDir / "config.json" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does this need to be a failure, or is a warning sufficient? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We tend to error for arguments that are not supported. |
||
let trackConfig = parseFile(trackConfigPath, TrackConfig) | ||
let trackExerciseSlugs = getSlugs(trackConfig.exercises, conf, trackConfigPath) | ||
|
@@ -36,6 +40,10 @@ proc create*(conf: Conf) = | |
let msg = "Please specify an exercise to create an article for, using --exercise <slug>" | ||
stderr.writeLine msg | ||
quit QuitFailure | ||
if conf.action.difficulty.isSome: | ||
let msg = "The difficulty argument is not supported for articles" | ||
stderr.writeLine msg | ||
quit QuitFailure | ||
let trackConfigPath = conf.trackDir / "config.json" | ||
let trackConfig = parseFile(trackConfigPath, TrackConfig) | ||
let trackExerciseSlugs = getSlugs(trackConfig.exercises, conf, trackConfigPath) | ||
|
@@ -55,6 +63,11 @@ proc create*(conf: Conf) = | |
|
||
createArticle(Slug(conf.action.articleSlug), userExercise, exerciseDir) | ||
elif conf.action.conceptExerciseSlug.len > 0: | ||
if conf.action.difficulty.isSome: | ||
let msg = "The difficulty argument is not supported for concept exercises" | ||
stderr.writeLine msg | ||
quit QuitFailure | ||
|
||
createConceptExercise(conf) | ||
elif conf.action.practiceExerciseSlug.len > 0: | ||
createPracticeExercise(conf) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is deliberately singular, as 99.99% of the time there is only one author.