Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(cli): Make showError quit with non-zero exit code #93

Merged

Conversation

ee7
Copy link
Member

@ee7 ee7 commented Nov 3, 2020

Previously, the program would incorrectly quit with an exit code of 0 for:

  • Invalid command-line parameters
  • Issues with a directory specified by -p, --prob-specs-dir

This PR also updates the test of the binary to check exit codes.

Previously, the program would incorrectly quit with an exit code of 0
for:
- Invalid command-line parameters
- Issues with a directory specified by `-p, --prob-specs-dir`

This commit also updates the test of the binary to check exit codes.
@ErikSchierboom ErikSchierboom merged commit 6504847 into exercism:master Nov 4, 2020
@ErikSchierboom
Copy link
Member

Thanks! A new release is being built.

@ee7 ee7 deleted the fix-cli-showError-quit-exit-code-1 branch November 4, 2020 11:14
ee7 added a commit to ee7/exercism-configlet that referenced this pull request Jan 21, 2021
Previously, the program would incorrectly quit with an exit code of 0
for:
- Invalid command-line parameters
- Issues with a directory specified by `-p, --prob-specs-dir`

This commit also updates the test of the binary to check exit codes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants