Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages in space-age exercise #68

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

pfertyk
Copy link
Contributor

@pfertyk pfertyk commented Jun 3, 2024

Fixes #67 .

Copy link

github-actions bot commented Jun 3, 2024

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@pfertyk pfertyk force-pushed the space-age-improved-error-message branch 4 times, most recently from a655858 to 5e8c37a Compare June 3, 2024 17:42
[no important files changed]
@pfertyk pfertyk force-pushed the space-age-improved-error-message branch from 5e8c37a to 556438d Compare June 3, 2024 17:48
@pfertyk
Copy link
Contributor Author

pfertyk commented Jun 3, 2024

@BNAndras I think this will help with obscure error messages in space-age exercise ;) Could you please take a look?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do we need to round the expected values though? I think we can just round the calculated age. That should make it a bit clearer what's going on hopefully.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last example was raising an error, saying that the expected value was 0.35, and the actual one 0.35 ... 🤔 So, just to be sure, I decided to round all the values 😛 That took care of the error 😉

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough

@pfertyk pfertyk merged commit ea21f1d into main Jun 3, 2024
2 checks passed
@pfertyk pfertyk deleted the space-age-improved-error-message branch June 3, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error messages in space_age exercise
2 participants