Predefine do_insert instead of do_delete in erlang_extraction #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because writing the insert function is the second task, I think it's more beneficial as a hint to predefine the private do_ function there so that beginners are not stuck on the different order of arguments. And then we can let the student figure this out on their own for the delete function
|
Ah, this was a mistake. There are not supposed to be any private functions included in the initial file. I'll remove it, thank you |
lpil
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because writing the insert function is the
secondthird task, I think it's more beneficial as a hint to predefine the private do_ function there so that beginners are not stuck on the different order of arguments. And then we can let the student figure this out on their own for the delete function