-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Lists concept #1134
base: main
Are you sure you want to change the base?
Add Lists concept #1134
Conversation
Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed. That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
@kytrinyx Going by
this should be merged now-ish. I expect all my insecurities about the text to be resolved through review by forum users, which can be held before or after merging. Only (nonspecific) insecurities about correct file structure remain. Do you foresee problems? |
@ErikSchierboom @petertseng I believe this PR was closed erroneously. As far as I know, Learning Mode PRs are still welcome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ErikSchierboom @petertseng I believe this PR was closed erroneously. As far as I know, Learning Mode PRs are #1132 (comment).
It's not. We only make an exception for not auto-closing PRs for approaches/articles. The linked issue indicates that PRs can be re-opened as desired, but it won't influence them being closed by default.
@@ -0,0 +1,3 @@ | |||
# About |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no such thing as an about.md.tpl
file.
The reason for that is that the about.md file should have different, more extensive contents than the introduction.
See https://exercism.org/docs/building/tracks/concepts
~~~~ | ||
|
||
|
||
## Lists representing text: `String` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would probably extract this to a separate concept.
@@ -0,0 +1,182 @@ | |||
# Introduction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This introduction document is quite large. As per the docs, we want it to be as minimal as possible.
That said, there is no exercise yet that teaches this concept, so it is not yet possible to determine the right level of detail.
No description provided.