Add extra test cases to Linked List #2332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-czigany
changed the title
sanderploegsma
approved these changes
Aug 28, 2023
There was a problem hiding this comment.
Good catch and thanks for your contribution!
Looking at the canonical data for this exercise there are no explicit test cases for push/pop/shift and shift/unshift/pop. However, the existing tests are not directly mapped to the canonical data anyway so IMO we can keep them, they might find some interesting bugs in student's solutions. 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test cases validating popping & shifting from an already "emptied" linked list.