-
-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add practice exercise markdown #1486
base: main
Are you sure you want to change the base?
Add practice exercise markdown #1486
Conversation
Dear KmelowThank you for contributing to the JavaScript track on Exercism! 💙
Dear Reviewer/Maintainer
Automated comment created by PR Commenter 🤖. |
Hello, Can I get feedback on the approach used for the file to refactor Thanks, |
@KMelow I am sorry, I cannot really help you with that. I don't have experiences with this exercise in other languages and with the Exercism refactoring exercises in general. I can only recommend looking at the stub files (that should be refactored) used in other languages (e.g. C#, python, Go) to get some inspiration. Maybe @SleeplessByte has some feedback on your approach to markdown.js. If not, I would recommend you just proceed as you see fit and we will see how the exercise is perceived later on. |
Hi there! Thanks for the work thusfar. I don't see anything particular that's really wrong, albeit this solution is likely going to fail quite a bit of markdown. That said, I won't be able to give you in-depth feedback until late next week. If you absolutely want that, feel free to wait on it, or, as @junedev suggest, keep on going. Thanks for your time investment! |
So, that's what I set out to do. I checked some PHP and python. I realized that there is a good amount of |
I don't think I got that, can you elaborate, please.
I'm planning to work more on it this weekend, so any input would be much appreciated. Thanks |
I think you're also on our Exercism Slack right? If you just want to hit me up tomorrow, given that I'm in |
Hum... don't think I got the invitation
It's all right, I'll do some other things and we can chat later during the week |
closes #918