-
-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update instructions.md #1802
base: main
Are you sure you want to change the base?
Update instructions.md #1802
Conversation
Multiplication (*) incorrectly represented via underscore character.
Dear dslettenThank you for contributing to the JavaScript track on Exercism! 💙
Dear Reviewer/Maintainer
Automated comment created by PR Commenter 🤖. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately this won't work, because the auto formatter will reformat it.
The way to solve this is to update this file against the common file, which escapes the *
characters. You can do this manually or follow the sync description.md instructions in our CONTRIBUTING.md file.
Would you be so kind to apply the further change? I'll run the CI for you so you can see why this PR doesn't work as is.
Hi, |
@dsletten As you can see in the CI checks, your proposed version does not pass the formatting check that is done for this tracks repository. Not all tracks do automated formatting checks, this is why your version might not cause issues in other tracks. The formatter we use thinks you want to create italic text with the SleeplessByte described above how you can avoid this issue so that your code can pass the formatting check and there will not be any issue in case someone runs auto-formatting on the code base. Would be great if you could follow the suggestion so we can get this merged. |
Multiplication (*) incorrectly represented via underscore character.